Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
Encoder.header_table_sizeto a new value and then setting the same value again clearsHeaderTable.resized. The pending size update is omitted from the next header block, so a peer that has acknowledged the smaller limit rejects it. A shrink to zero followed by a restore can instead leave the encoder and decoder with different dynamic entries.Skip the table assignment when the size is unchanged, preserving the pending update. The regression checks repeated assignments after shrinking to zero, shrinking to a nonzero limit, and clearing then restoring the table. It also checks that the update is only emitted once.
Validation: the three regression cases fail on the original source; the full suite passes with 505 tests and 100% statement/branch coverage. Ruff, mypy, check-manifest, wheel/sdist builds, twine check, and the HTML docs build pass on Python 3.12.2. Existing Hypothesis initialization warnings remain; the docs build reports one unresolved link in the unchanged installation guide.